Generate SyntaxError of global declaration #74
Conversation
Generate SyntaxError instead of SyntaxWarning if global declaration is for priviously used variable Fixes go-python#72
|
@HyeockJinKim |
|
@ncw |
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 68.65% 68.65%
=======================================
Files 59 59
Lines 10525 10525
=======================================
Hits 7226 7226
Misses 2790 2790
Partials 509 509
Continue to review full report at Codecov.
|
|
@corona10 Can I get a review? |
There was a problem hiding this comment.
@HyeockJinKim
It looks working well but I am not sure this is the right way to deal with.
Let's wait @ncw 's review
|
I think the code looks nice :-) However it makes gpython incompatible with python3.4 as I wrote here: #72 (comment) Now I don't think any of the tests rely on that so it is safe to change it. What do you think @corona10 - make a break with python3.4 compatibility here? On balance I think it is a good idea since this is almost always an actual problem. PS the commits need squashing which can be done at merge time |
|
@ncw |
OK, lets squash and merge :-) |
|
@HyeockJinKim |
Generate SyntaxError instead of SyntaxWarning
if global declaration is for priviously used variable
Fixes #72