Add sorted and list.sort
#81
Conversation
Mostly finished, needs some argument parsing changes.
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=========================================
+ Coverage 68.65% 69.36% +0.7%
=========================================
Files 59 60 +1
Lines 10525 10778 +253
=========================================
+ Hits 7226 7476 +250
+ Misses 2790 2775 -15
- Partials 509 527 +18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@Tim-St Hi, Thanks for the contribution.
I know implementing sort for python interpreter(tim sort) is very hard.
Would you like to add the test about the list for your change?
The test should be run at here.
https://github.com/go-python/gpython/blob/master/py/tests/list.py
Might be coverage will be increased.
|
@corona10 Ok, I will add some test cases. |
|
@Tim-St Thanks for the information! |
|
I will add one more thing. a = [1,3,2]
assert list.sort(a) is None
assert a == [1, 2, 3]should work. Currently this syntax doesn't work for |
|
@ncw Thanks! I'd like to change it to get a higher score, but I don't understand how "codecov" measures the results, and there are no hints on the page which parts should be changed :\ |
:-) The output is a bit cryptic The easiest way to improve the coverage is to use the go coverage tools locally to see the bits which haven't been covered in the code you've added. Cover those and the coveralls score will increase! |
|
Hm, when I run this |
|
@Tim-St |
No description provided.