Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Release v1.9.3 #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Release v1.9.3 #1724

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1bee809
test stability improvement. (#1699)
methane Apr 21, 2025
ac04e5f
Transaction Commit/Rollback returns conn's cached error (#1702)
methane Apr 22, 2025
2ed589b
backport benchmark_test (#1706)
methane Apr 23, 2025
dfd973a
optimize readPacket (#1707)
methane Apr 25, 2025
324cbb3
[1.9] fix PING on compressed connections (#1723)
methane Jun 13, 2025
8c57c41
release v1.9.3
methane Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Transaction Commit/Rollback returns conn's cached error (#1702) 
If a transaction connection has a cached error, return it instead of
ErrInvalidConn during Commit/Rollback operations.

Fix #1690

Co-authored-by: brad-defined <[email protected]>
  • Loading branch information
@methane @brad-defined
methane and brad-defined authored Apr 22, 2025
commit ac04e5f831c049a1ccf04bd2d62211b26f6b7cd9
2 changes: 2 additions & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Asta Xie <xiemengjun at gmail.com>
B Lamarche <blam413 at gmail.com>
Bes Dollma <[email protected]>
Bogdan Constantinescu <bog.con.bc at gmail.com>
Brad Higgins <brad at defined.net>
Brian Hendriks <brian at dolthub.com>
Bulat Gaifullin <gaifullinbf at gmail.com>
Caine Jette <jette at alum.mit.edu>
Expand Down Expand Up @@ -134,6 +135,7 @@ Ziheng Lyu <zihenglv at gmail.com>

Barracuda Networks, Inc.
Counting Ltd.
Defined Networking Inc.
DigitalOcean Inc.
Dolthub Inc.
dyves labs AG
Expand Down
18 changes: 16 additions & 2 deletions transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,32 @@ type mysqlTx struct {
}

func (tx *mysqlTx) Commit() (err error) {
if tx.mc == nil || tx.mc.closed.Load() {
if tx.mc == nil {
return ErrInvalidConn
}
if tx.mc.closed.Load() {
err = tx.mc.error()
if err == nil {
err = ErrInvalidConn
}
return
}
err = tx.mc.exec("COMMIT")
tx.mc = nil
return
}

func (tx *mysqlTx) Rollback() (err error) {
if tx.mc == nil || tx.mc.closed.Load() {
if tx.mc == nil {
return ErrInvalidConn
}
if tx.mc.closed.Load() {
err = tx.mc.error()
if err == nil {
err = ErrInvalidConn
}
return
}
err = tx.mc.exec("ROLLBACK")
tx.mc = nil
return
Expand Down