Update README.md #23
Merged
Update README.md #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
reviewed
Jul 25, 2017
README.md
Outdated
| * How to register exports like gdscript | ||
| * export var _name = "SimpleClass" | ||
| **/ | ||
| register_property((char *)"base/name", &SimpleClass::_name, Variant("SimpleClass")); |
There was a problem hiding this comment.
The default value must have the se type as the member pointer but here it's Variant. If it is a String then you must put a String there
There was a problem hiding this comment.
Updated, was really in hurry, you should wait until godot_header README is updated as creating .gdns is left out.
karroffel
reviewed
Jul 25, 2017
| Building core/bindings, (`libgodot_cpp_core.so` , `libgodot_cpp_bindings.so`) | ||
| Building bindings in linux,(`libgodot_cpp_bindings.a`) | ||
| ``` | ||
| $ scons p=linux |
There was a problem hiding this comment.
This line isn't needed anymore as everything gets compiled at once.
mashumafi
pushed a commit
to mashumafi/godot-cpp
that referenced
this pull request
Feb 3, 2023
pattlebass
pushed a commit
to pattlebass/grafic-gdextension
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.