Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix issue 5284 by making sure every opening tag gets closed in markdown #6622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix issue 5284 by making sure every opening tag gets closed in markdown #6622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a9bff5
fix issue 5284 by adding missing self closing tag
idonov8 Sep 26, 2021
154681c
Add checks to prevent errors in rendering html
idonov8 Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions internal/markup/markup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ package markup
import (
"bytes"
"fmt"
"io"
"strings"

"github.com/unknwon/com"
Expand Down Expand Up @@ -170,7 +169,7 @@ var (
rightAngleBracket = []byte(">")
)

var noEndTags = []string{"input", "br", "hr", "img"}
var noEndTags = []string{"input", "br", "hr", "img", "sup"}

// wrapImgWithLink warps link to standalone <img> tags.
func wrapImgWithLink(urlPrefix string, buf *bytes.Buffer, token html.Token) {
Expand Down Expand Up @@ -289,27 +288,27 @@ OUTER_LOOP:
}

case html.EndTagToken:
if len(startTags) == 0 {
buf.WriteString(token.String())
break
if com.IsSliceContainsStr(startTags, token.Data){
for startTags[len(startTags)-1] != token.Data && len(startTags) > 1 {
buf.WriteString(ClosingTag(startTags[len(startTags)-1]))
startTags = startTags[:len(startTags)-1]
}
buf.WriteString(ClosingTag(startTags[len(startTags)-1]))
startTags = startTags[:len(startTags)-1]
}

buf.Write(leftAngleBracket)
buf.WriteString(startTags[len(startTags)-1])
buf.Write(rightAngleBracket)
startTags = startTags[:len(startTags)-1]
default:
buf.WriteString(token.String())
}
}

if io.EOF == tokenizer.Err() {
return buf.Bytes()
for i := len(startTags)-1; i >= 0; i-- {
buf.WriteString(ClosingTag(startTags[i]))
}

// If we are not at the end of the input, then some other parsing error has occurred,
// so return the input verbatim.
return rawHTML
return buf.Bytes()
}
func ClosingTag(s string) string{
return string(leftAngleBracket) + s + string(rightAngleBracket)
}

type Type string
Expand Down