Adding ACL List, Show Cli #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
March 22, 2019 22:23
Advantage of this can seperate cmds, and import only the ones that are required
Collaborator
Author
|
@rShetty this is done and ready for review. Will be adding create, edit cli's in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weaver CLI is ready for review.
Commands will register them selves with CLI. In main we need to import the commands that we want them to be with the binary.
Let's say we want to separate out acls commands, we can create weaverctl in cmd/weaverctl and import only acl commands. Binary produced from weaverctl will have only acls commands and will not have acl commands.
View layers currently renders output to json, this can manipulated easily using a flag and rending to outputs like yaml, table and etc. This will be a enhancement. For now will stick to json output.