Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Builder foundation work #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Builder foundation work #182

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
bcd6c35
Update builder_snapper files.
rsned May 4, 2025
3ab23c5
Define the builder options type and its two helper methods.
rsned May 10, 2025
1d63448
add header text
rsned May 10, 2025
09f7532
Add builders layer interface.
rsned May 10, 2025
51ac9e3
Add the base builder type with its extensive comment block.
rsned May 10, 2025
a95103b
Add builder graph options and related enums.
rsned May 10, 2025
0b2af37
Add initial builder graph type and related enums.
rsned May 10, 2025
af0ce50
Add more types to graph options.
rsned May 10, 2025
6084658
Add another batch of builder internal variables and update init.
rsned May 10, 2025
0b5e252
change polylinetype to package private like the other builder enums.
rsned May 11, 2025
6435633
Add remaining builder datastructure elements and finish init().
rsned May 11, 2025
45220f6
update comments and move edge_type to graph_options next to the other…
rsned May 18, 2025
38bd88b
minor enum shuffling
rsned May 18, 2025
03f216d
Add S2Builder Graph's EdgeProcessor class to Go with unit tests.
rsned May 18, 2025
4269fec
fix some staticcheck lint errors.
rsned May 18, 2025
d5f81d3
Update edgeProcessor and add a few more test cases to cover more bran…
rsned May 19, 2025
2ce78ad
simplify test merge input ids setup.
rsned May 19, 2025
e2d1225
Merge branch 'master' into builder-foundations
rsned May 19, 2025
c295223
Rename edge->graphEdge throughout, fix error exit case.
rsned May 28, 2025
463a9e0
Merge branch 'builder-foundations' of ssh://github.com/rsned/geo into…
rsned May 29, 2025
7b462a4
Add all of the test cases for graphEdgeProcessor's Run from C++
rsned May 29, 2025
a2bb0fe
Roll options back into the file of the same name.
rsned May 29, 2025
d817c66
Move graphEdgeProcessor and tests into builder_graph.go and tests.
rsned May 29, 2025
b68663f
Add comments to remaining member variables in Builder and Graph.
rsned May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more types to graph options.
  • Loading branch information
@rsned
rsned committed May 10, 2025
commit af0ce5088af0551a4b3f1b37c51d141ffd442e10
15 changes: 9 additions & 6 deletions s2/builder_graph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,13 @@ type graphEdge struct {
// TODO(rsned): Consider pulling out the methods that are helper functions for
// Layer implementations (such as getDirectedLoops) into a builder_util_graph.go.
type graph struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In C++ this is S2Builder::Graph and in Java it's S2BuilderGraph. Does this function as a general-purpose graph, or should this be s2.BuilderGraph?

opts *graphOptions
numVertices int
vertices []Point
edges []graphEdge

// TODO(rsned): Add remaining elements.
opts *graphOptions
numVertices int
vertices []Point
edges []graphEdge
inputEdgeIDSetIDs []int32
inputEdgeIDSetLexicon *idSetLexicon
labelSetIDs []int32
labelSetLexicon *idSetLexicon
isFullPolygonPredicate isFullPolygonPredicate
}