Thanks to visit codestin.com
Credit goes to github.com

Skip to content

go/types/objectpath: reduce allocations with sync.Pool#613

Open
ewhauser wants to merge 2 commits intogolang:masterfrom
ewhauser:objectpath-reduce-allocations
Open

go/types/objectpath: reduce allocations with sync.Pool#613
ewhauser wants to merge 2 commits intogolang:masterfrom
ewhauser:objectpath-reduce-allocations

Conversation

@ewhauser
Copy link

@ewhauser ewhauser commented Jan 6, 2026

Use sync.Pool to reuse byte buffers and finder structs,
reducing allocations by ~52% in heavy-usage scenarios.

  • Add pathBufPool for reusing path encoding buffers
  • Add smallInts lookup table for integers 0-99
  • Add finderPool for reusing finder structs

Benchmarking on a 9000-package monorepo with ~40 analyzers showed:

  • Allocations: 929MB → 445MB (52% reduction)
  • GC cycles: 21 → 14 (33% reduction)
  • GC pause time: 1.77ms → 0.81ms (54% reduction)

Fixes golang/go#77059

@ewhauser
go/types/objectpath: reduce allocations with sync.Pool
0114d45 
Use sync.Pool to reuse byte buffers and finder structs,
reducing allocations by ~52% in heavy-usage scenarios.

- Add pathBufPool for reusing path encoding buffers
- Add smallInts lookup table for integers 0-99
- Add finderPool for reusing finder structs

Benchmarking on a 9000-package monorepo with ~40 analyzers showed:
- Allocations: 929MB → 445MB (52% reduction)
- GC cycles: 21 → 14 (33% reduction)
- GC pause time: 1.77ms → 0.81ms (54% reduction)

Fixes golang/go#77059
@ewhauser ewhauser mentioned this pull request Jan 6, 2026
Open
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2026

This PR (HEAD: 0114d45) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/734140.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2026

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/734140.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2026

Message from Daniel Morsing:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/734140.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2026

Message from Alan Donovan:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/734140.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2026

This PR (HEAD: 343bf99) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/734140.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

gopherbot commented Jan 8, 2026

Message from Alan Donovan:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/734140.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jan 8, 2026

Message from Alan Donovan:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/734140.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

x/tools/go/types/objectpath: reduce allocations with sync.Pool

2 participants

@ewhauser @gopherbot