Codestin Search App

dcalsky · 2023-04-02T15:17:14Z

This PR reduces the scope of ToLower for strings and can provide a significant performance gain when validating Token Strings.

import (
	"strings"
	"testing"
)

var (
	authA = "Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyIxMjMiOiJka2FzbDtka2FzO2xka2FzbDtka2FzbDtka2FzbDtka2FsO3NrZGw7Y216eC4sbWMsLnp4bWMueix4bWMuLHp4bWMuengsbWMsLnp4bWMuLHp4bWMuLHp4bSxjLiIsImlhdCI6MTY4MDQ0Nzg2OX0.E9n6tm0P1-Z_fj7RmGpk6RpPMQzTJuo7knKNM0sBhvk"
)

func BenchmarkBearer(b *testing.B) {
	b.Run("previous", func(b *testing.B) {
		b.ResetTimer()
		for i := 0; i < b.N; i++ {
			strings.HasPrefix(strings.ToLower(authA), "bearer ")
		}
	})
	b.Run("now", func(b *testing.B) {
		b.ResetTimer()
		for i := 0; i < b.N; i++ {
			strings.HasPrefix(strings.ToLower(authA[:7]), "bearer ")
		}
	})
}

goos: darwin
goarch: arm64
pkg: awesomeProject
BenchmarkBearer
BenchmarkBearer/previous
BenchmarkBearer/previous-10         	 1675801	       719.9 ns/op
BenchmarkBearer/now
BenchmarkBearer/now-10              	40375887	        28.59 ns/op

oxisto · 2023-04-02T15:48:22Z

Wow, to be honest I would not have thought that this is an issue. I wonder why the implementation of HasPrefix does not abort searching the string after n bytes. I will also look at this in the coming days if we have sufficient tests.

Update: Nevermind, obviously the ToLower was the problem here

dcalsky · 2023-04-02T15:59:05Z

Wow, to be honest I would not have thought that this is an issue. I wonder why the implementation of HasPrefix does not abort searching the string after n bytes. I will also look at this in the coming days if we have sufficient tests.

Update: Nevermind, obviously the ToLower was the problem here

Hundreds of projects use this library for authentication, so I want to improve the performance of it as much as possible :D

request/extractor.go

parser.go

oxisto · 2023-07-18T06:52:46Z

LGTM. Sorry for the long delay, I think we can ignore the 0.03 % coverage loss

cc @mfridman

cbandy · 2023-08-18T17:58:28Z

request/extractor.go

 	// The usual convention is for "Bearer" to be title-cased. However, there's no
 	// strict rule around this, and it's best to follow the robustness principle here.
-	if tokenHeader == "" || !strings.HasPrefix(strings.ToLower(tokenHeader), "bearer ") {
+	if len(tokenHeader) < 7 || !strings.HasPrefix(strings.ToLower(tokenHeader[:7]), "bearer ") {


This is late and a nitpick, but HasPrefix also slices the front. Is it faster to drop the call completely?

Suggested change

if len(tokenHeader) < 7 || !strings.HasPrefix(strings.ToLower(tokenHeader[:7]), "bearer ") {

if len(tokenHeader) < 7 || strings.ToLower(tokenHeader[:7]) != "bearer " {

We adjusted it in a follow-up PR: https://github.com/golang-jwt/jwt/pull/329/files

dcalsky changed the title ~~quick way to validate token string~~ A quick way to validate token string Apr 2, 2023

oxisto previously approved these changes Apr 2, 2023

View reviewed changes

mfridman reviewed Apr 10, 2023

View reviewed changes

request/extractor.go Outdated Show resolved Hide resolved

dcalsky dismissed oxisto’s stale review via 6b99099 April 10, 2023 02:45

dcalsky force-pushed the perf_bearer branch from e7729d5 to 6b99099 Compare April 10, 2023 02:45

oxisto reviewed Apr 10, 2023

View reviewed changes

parser.go Outdated Show resolved Hide resolved

perf: quick way to validate token string

c4d17e4

dcalsky force-pushed the perf_bearer branch from 6b99099 to c4d17e4 Compare April 10, 2023 11:46

oxisto approved these changes Jul 18, 2023

View reviewed changes

mfridman approved these changes Jul 20, 2023

View reviewed changes

oxisto merged commit 8b7470d into golang-jwt:main Jul 20, 2023

alexandear mentioned this pull request Aug 3, 2023

Refactor: compare strings with strings.EqualFold #329

Merged

cbandy reviewed Aug 18, 2023

View reviewed changes

oxisto mentioned this pull request Nov 8, 2023

docs: add CHANGELOG.md #326

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A quick way to validate token string#302

A quick way to validate token string#302
oxisto merged 1 commit intogolang-jwt:mainfrom
dcalsky:perf_bearer

dcalsky commented Apr 2, 2023

Uh oh!

oxisto commented Apr 2, 2023 •

edited

Loading

Uh oh!

dcalsky commented Apr 2, 2023

Uh oh!

Uh oh!

Uh oh!

oxisto commented Jul 18, 2023

Uh oh!

cbandy Aug 18, 2023

Uh oh!

oxisto Aug 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	if len(tokenHeader) < 7 \|\| !strings.HasPrefix(strings.ToLower(tokenHeader[:7]), "bearer ") {
	if len(tokenHeader) < 7 \|\| strings.ToLower(tokenHeader[:7]) != "bearer " {

Conversation

dcalsky commented Apr 2, 2023

Uh oh!

oxisto commented Apr 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcalsky commented Apr 2, 2023

Uh oh!

Uh oh!

Uh oh!

oxisto commented Jul 18, 2023

Uh oh!

cbandy Aug 18, 2023

Choose a reason for hiding this comment

Uh oh!

oxisto Aug 18, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oxisto commented Apr 2, 2023 •

edited

Loading