Merged
Conversation
Member
|
If you want to go all the way, you can run this command against the root of the repository: go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix ./...Might as well do it once programmatically instead of manually. |
ba00555 to
fc91ab1
Compare
mfridman
approved these changes
Jun 7, 2025
Member
|
And then look for all comments |
mfridman
approved these changes
Jun 12, 2025
oxisto
approved these changes
Jun 12, 2025
|
Cool! The guy has a great future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I replaced interface{} to its alias any