Allow TRUNCATE for MySQL #1010
Closed
Allow TRUNCATE for MySQL #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI lint failure is not due to my changes, but because master itself is not compliant. |
|
Could this be solved by adding a |
|
Closing this in favor of #1070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #864 which originates from #656.
I agree that proper isolation is a must, but my database forces safe updates, which the current
DELETE-query does not adhere to. To resolve that, I've added a simple switch to choose betweenDELETEandTRUNCATE.Not sure if this is the best solution (we could also wrap the
DELETEwithSET SQL_SAFE_UPDATES), so feel free to edit/comment/etc.