Thanks to visit codestin.com
Credit goes to github.com

Skip to content

postgres: Move lock out of ensureVersionTable, for consistency with other SQL operations #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 26, 2019
Merged

postgres: Move lock out of ensureVersionTable, for consistency with other SQL operations #173

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6d8499a
Consistently lock in ensureVersionTable and do not call ensureVersion…
Feb 18, 2019
36d865c
Add test for dropping postgres databases
Feb 18, 2019
9d8ef5e
Fix failing database tests
Feb 18, 2019
45d3ba3
Fix CockroachDb test, lock table should be created before versionTable
Feb 18, 2019
3fd5314
Add Initialize() to Driver interface, and add integration tests for D…
Feb 19, 2019
b1a122c
Remove Initialize, document breaking behaviour of Drop
Feb 20, 2019
65e59b3
Revert introduction of Initialize method
Feb 20, 2019
4f62649
Removed Initialize in Stub as well
Feb 20, 2019
dc96daa
Remove call to non-existent Initialize and make sure to close re-init…
Feb 20, 2019
d8df31c
Revert changes to TestDrop in database/testing
Feb 20, 2019
7e74b8e
Split Test and TestMigrate into different test entrypoints
Feb 21, 2019
9aaa875
Remove unused import in migrate_testing
Feb 21, 2019
5d8e5e9
Remove erroneous code to fix tests
Feb 21, 2019
499415a
Add stub source imports to database tests
Feb 21, 2019
2b491b9
Add Stub source to migrate tests
Feb 21, 2019
d8bff44
Use example migrations for tests
Feb 21, 2019
27a85dd
Add file driver to database tests
Feb 21, 2019
28d69a0
Align database directory layout
Feb 21, 2019
179720d
Add file source driver to Cassandra
Feb 21, 2019
170d309
Review changes
Feb 26, 2019
4c3f71f
Minor syntactic change for cleaner diff
Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Minor syntactic change for cleaner diff
  • Loading branch information
Lukas Jørgensen (LUJOR) committed Feb 26, 2019
commit 4c3f71fb625b9b5a78e00c00c191331fb60c4b20
2 changes: 1 addition & 1 deletion database/postgres/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func WithInstance(instance *sql.DB, config *Config) (database.Driver, error) {
config: config,
}

if err = px.ensureVersionTable(); err != nil {
if err := px.ensureVersionTable(); err != nil {
return nil, err
}

Expand Down