Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Gitlab source #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 11, 2019
Merged

Gitlab source #184

merged 5 commits into from
Mar 11, 2019

Conversation

bpatyi
Copy link
Contributor

@bpatyi bpatyi commented Mar 7, 2019 •
edited
Loading

I add new gitlab source to the project.

I created the pr as you asked @dhui

dhui
dhui requested changes Mar 7, 2019
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thannks for the PR!

I'm not sure why CI didn't run, but the next push should kick off a build...

go.mod
github.com/smartystreets/goconvey v0.0.0-20180222194500-ef6db91d284a // indirect
github.com/stretchr/testify v1.3.0 // indirect
github.com/tidwall/pretty v0.0.0-20180105212114-65a9db5fad51 // indirect
github.com/xanzy/go-gitlab v0.15.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts and regenerate using go mod tidy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.

source/gitlab/gitlab.go Outdated
}

if u.Host != "" {
err = gn.client.SetBaseURL("https://" + u.Host)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use net/url to build the string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it too.

@coveralls
Copy link

coveralls commented Mar 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 352

  • 3 of 142 (2.11%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.8%) to 52.818%
Changes Missing Coverage Covered Lines Changed/Added Lines %
source/gitlab/gitlab.go 3 142 2.11%
Totals Coverage Status
Change from base Build 350: -6.8%
Covered Lines: 731
Relevant Lines: 1384
💛 - Coveralls

dhui
dhui previously approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, if you want the Gitlab source included by default, you'll need to add it to the SOURCE environment variable in Makefile and Dockerfile

@dhui dhui merged commit 144aaaa into golang-migrate:master Mar 11, 2019
@renovate renovate bot mentioned this pull request May 29, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpatyi @coveralls @dhui