Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enabled maligned, staticcheck and errcheck linters #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Apr 26, 2019
Merged

Enabled maligned, staticcheck and errcheck linters #206

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
ad9d800
Enabled maligned check
kmuratov Mar 29, 2019
e932b05
Enabled staticcheck
kmuratov Mar 29, 2019
75f1059
Fixes for golint
kmuratov Mar 29, 2019
faafed1
Enabled errcheck linter
kmuratov Mar 30, 2019
6f0acbf
Added fixes for error check
kmuratov Apr 14, 2019
54998e5
Merge branch 'master' into issue-125
kmuratov Apr 17, 2019
a501fc3
Added errcheck for tests
Apr 17, 2019
826b766
Fixed test
Apr 17, 2019
7f72c4c
Increased golangci-lint deadline for travis
Apr 17, 2019
7e419d3
Increased golangci-lint deadline for travis
Apr 17, 2019
4662992
Merge remote-tracking branch 'origin/issue-125' into issue-125
Apr 17, 2019
bcff2ef
Decreased golangci-lint deadline for travis
Apr 19, 2019
39dddb5
Revert for backward compatibility
Apr 19, 2019
7e77100
Using log.Println() instead of fmt.Println()
Apr 19, 2019
edb3a4e
Handling os.RemoveAll() errors
Apr 19, 2019
1bce95e
Using t.Error(error) instead of t.Errorf("%v", err)
Apr 19, 2019
81a642b
Using t.Fatal(error) instead of t.Fatalf("%v", err)
Apr 19, 2019
21801e0
Using fmt.Sprint(sum) instead of t.Srintf("%v", sum)
Apr 19, 2019
47fa45a
Refactoring
Apr 19, 2019
343b35c
Revert for backward compatibility
Apr 19, 2019
bbe0f3c
Revert
Apr 19, 2019
62bebbf
go mod tidy
Apr 19, 2019
05e3176
Added error logging
Apr 19, 2019
ecb6171
Added error logging
Apr 19, 2019
9ad81a3
Added error handling
Apr 19, 2019
4ca5c47
Added error handling
Apr 19, 2019
e6d53b9
Added error logging
Apr 19, 2019
ee02b64
Fix error logging
Apr 22, 2019
4348dab
Added error handling
Apr 22, 2019
ed6965b
Fix
Apr 22, 2019
303b059
Added logging for migr.Buffer()
Apr 22, 2019
96f0e41
Fixes
Apr 26, 2019
a7ca9da
Firebird test disabled
Apr 26, 2019
ae47e06
Fixed nolint comment
Apr 26, 2019
08edc83
Updated firebird docker image version
Apr 26, 2019
84081f4
Disabled test for firebird 2.5
kmuratov Apr 26, 2019
395b28e
Fixed // nolint
kmuratov Apr 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added error handling
  • Loading branch information
Kirill Muratov committed Apr 19, 2019
commit 9ad81a381be241b72652e8c47d193d2c4b737f3d
7 changes: 5 additions & 2 deletions migrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,8 +762,11 @@ func (m *Migrate) versionExists(version uint) (result error) {
// then try down migration
down, _, err := m.sourceDrv.ReadDown(version)
if err == nil {
// nolint: errcheck
defer down.Close()
defer func() {
if errClose := down.Close(); errClose != nil {
result = multierror.Append(result, errClose)
}
}()
}
if os.IsExist(err) {
return nil
Expand Down