Add WithSession helper for Cassandra driver #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes method receivers names for the Cassandra struct to "c" since "p" makes no sense in this context.
database/cassandra/cassandra.go
Outdated
| } | ||
|
|
||
| func (p *Cassandra) Open(url string) (database.Driver, error) { | ||
| func WithSession(session *gocql.Session, config *Config) (database.Driver, error) { |
There was a problem hiding this comment.
for consistency with all the other drivers, shouldn't the name remain as WithInstance?
There was a problem hiding this comment.
Agreed, use the name WithInstance for consistency
dhui
reviewed
May 16, 2018
database/cassandra/cassandra.go
Outdated
| } | ||
|
|
||
| func (p *Cassandra) Open(url string) (database.Driver, error) { | ||
| func WithSession(session *gocql.Session, config *Config) (database.Driver, error) { |
There was a problem hiding this comment.
Agreed, use the name WithInstance for consistency
|
@dhui Added both requests. Travis still seems to be failing. I am unsure how these changes are affecting the tests, since (at least before the lock change) it's just a variable name change and a completely new function. |
|
Yeah, I don't think your changes are related to the failing tests. Thanks for the PR! I'll merge in your changes, but if you wanna use them, use the master branch as the failing tests are release blockers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11.
Also tweaks the method receivers to match the struct name.