Fix issues with Neo driver #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neo4J Support in Go Migrate [WIP]
|
Turns out that there were unreported errors while running, and neo4j.Collect should make them visible and actionable. Also fixing tests that fail now that the errors are visible |
Pull Request Test Coverage Report for Build 636
💛 - Coveralls |
dhui
requested changes
Jan 18, 2020
|
@dhui because of this issue: Turns out that session.Run doesn't return an error if the query fails, nor does the result, until the result is "consumed". neo4j.Collect is a utility function that runs and consumers, and returns the errors and results directly |
dhui
requested changes
Jan 19, 2020
go.mod
Outdated
| github.com/neo4j-drivers/gobolt v1.7.4 // indirect | ||
| github.com/neo4j/neo4j-go-driver v1.7.4 | ||
| github.com/pkg/errors v0.8.1 // indirect | ||
| github.com/prometheus/common v0.2.0 |
There was a problem hiding this comment.
Run go mod tidy. This line should go away
dhui
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.