Allow for multistatement migrations in Neo4j #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 654
💛 - Coveralls |
dhui
requested changes
Jan 21, 2020
There was a problem hiding this comment.
Migrations in migrate are treated as opaque blobs: https://github.com/golang-migrate/migrate/blob/master/MIGRATIONS.md#migration-content-format
To support multiple statements in a migration, add a x-multi-statement option and document accordingly. See the cassandra and clickhouse drivers as an example.
9b8889f to
ae1cc1a
Compare
dhui
requested changes
Jan 22, 2020
database/neo4j/neo4j.go
Outdated
| URL: uri.String(), | ||
| AuthToken: authToken, | ||
| MigrationsLabel: DefaultMigrationsLabel, | ||
| MultiStatement: multi == "true", |
There was a problem hiding this comment.
Use strconv.ParseBool() and handle the error properly
database/neo4j/neo4j.go
Outdated
| if _, err := neo4j.Collect(session.Run(string(body[:]), nil)); err != nil { | ||
| return err | ||
| if n.config.MultiStatement { | ||
| statements := bytes.Split(body, []byte{';'}) |
There was a problem hiding this comment.
Might as well make the separate an internal package level variable/constant
There was a problem hiding this comment.
Pulled into a constant
dhui
requested changes
Jan 22, 2020
dhui
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.