When reaching end of migrations treat as no change #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning a file not found error when no more changes are available, return a no change message. Fixes golang-migrate#35 Fixes golang-migrate#312
1a1756d to
ff3cad2
Compare
Pull Request Test Coverage Report for Build 757
💛 - Coveralls |
dhui
requested changes
Apr 21, 2020
| // reached end, and didn't apply any migrations | ||
| if limit > 0 && count == 0 { | ||
| ret <- os.ErrNotExist | ||
| ret <- ErrNoChange |
There was a problem hiding this comment.
This error is returned when a limit has been specified. e.g. you know how many migrations you expect to be run. So os.ErrNotExist is the correct error to return in this case.
There was a problem hiding this comment.
You're right. However, I gave to say I've made this mistake because the documentation and examples was not clear enough to me, can I help on this?
There was a problem hiding this comment.
Yep, feel free to update the docs! The FAQ might be a good place to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning a file not found error when no more changes are available, return a no change message.
Fixes #35
Fixes #312