Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Include file path in errors from PartialDriver.ReadUp() and ReadDown() #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2020
Merged

Include file path in errors from PartialDriver.ReadUp() and ReadDown() #421

merged 2 commits into from
Aug 29, 2020

Conversation

leventov
Copy link
Contributor

Helps to diagnose errors like #79

dhui
dhui requested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@leventov leventov force-pushed the migration-error-clarify branch from 6bd94ef to 8d5eb7f Compare August 28, 2020 07:07
dhui
dhui requested changes Aug 28, 2020
View reviewed changes
dhui
dhui requested changes Aug 28, 2020
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestRead, TestReadUp, and TestReadDown need to be updated to expect an os.PathError with the underlying error as os.ErrNotExist

@leventov leventov force-pushed the migration-error-clarify branch from 8d5eb7f to 6f3e6ae Compare August 29, 2020 08:27
@leventov leventov force-pushed the migration-error-clarify branch from 6f3e6ae to 04fb8d6 Compare August 29, 2020 09:50
@coveralls
Copy link

coveralls commented Aug 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 845

  • 19 of 27 (70.37%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 53.261%
Changes Missing Coverage Covered Lines Changed/Added Lines %
source/httpfs/partial_driver.go 7 15 46.67%
Totals Coverage Status
Change from base Build 841: -0.03%
Covered Lines: 2646
Relevant Lines: 4968
💛 - Coveralls

@leventov
Copy link
Contributor Author

@dhui Fixed. Build failure now seems because of docker container pull problems only.

@dhui dhui merged commit f1cf81e into golang-migrate:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leventov @coveralls @dhui