Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replacing Github with GitHub. #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2020
Merged

Replacing Github with GitHub. #429

merged 2 commits into from
Aug 17, 2020

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 17, 2020

Done via:

$ git grep -l Github | xargs sed -i '' s/Github/GitHub/g

Replacing Github with GitHub.
e626941 
Done via:

```
$ git grep -l Github | xargs sed -i '' s/Github/GitHub/g
```
@dhermes
Copy link
Contributor Author

dhermes commented Aug 17, 2020

No worries if you don't want to merge this, or if you want to say no to the changes to .go source files. I realize I'm just a random person on GitHub, so no expectation this will be merged.

Thanks for the great project!

dhui
dhui requested changes Aug 17, 2020
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating docs and comments are fine, but don't update exported variables, structs, etc to maintain backwards compatibility

@coveralls
Copy link

coveralls commented Aug 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 834

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.29%
Totals Coverage Status
Change from base Build 831: 0.0%
Covered Lines: 2640
Relevant Lines: 4954
💛 - Coveralls

@dhermes
Copy link
Contributor Author

dhermes commented Aug 17, 2020 •
edited
Loading

Updating docs and comments are fine, but don't update exported variables, structs, etc to maintain backwards compatibility

Sure thing, I reverted the changes to all .go files. Will go over a bit more closely and see if there is any godoc content that can be updated. (Nope)

@dhui dhui merged commit 6035eb5 into golang-migrate:master Aug 17, 2020
@dhermes dhermes deleted the github-capital-h branch August 17, 2020 21:01
@renovate renovate bot mentioned this pull request May 27, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @coveralls @dhui