sqlite3: Add test case with database path contains whitespace #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhui
requested changes
Jan 27, 2021
database/sqlite3/sqlite3.go
Outdated
| return nil, err | ||
| } | ||
| dbfile := strings.Replace(migrate.FilterCustomQuery(purl).String(), "sqlite3://", "", 1) | ||
| dbfile, err = nurl.QueryUnescape(dbfile) |
There was a problem hiding this comment.
The whole connection string cannot be unescaped as the options need to be escaped.
I think we'll need to reconstruct the connection string w/ the host & path unescaped unless you can think of a cleaner way...
Example of what the parsed connection string looks like
e540d4f to
ff84451
Compare
ganboonhong
commented
Jan 29, 2021
dhui
requested changes
Jan 29, 2021
446b7f8 to
0051a19
Compare
|
Thanks for the suggestion! Already modified the code. |
dhui
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #499
Since URL will be encoded using percent-encoding in
migrate/database/sqlite3/sqlite3.go
Line 95 in 550193e
urllike/path/to database/(it contains whitespace) will be encoded to/path/to%20database/, which causesmigrate/database/sqlite3/sqlite3.go
Line 47 in 550193e
to return an error.