Implement WithConnection for pgx and pgx5 database drivers #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhui Sorry to ping again, but I just wanted to check if there's anything else I can do to help move this PR forward. We're hoping to use this to implement a migrator that can be closed without closing the underlying connection pool using the Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable consumers to provide an existing *sql.DB with the option to close the connection without closing the underlying *sql.DB instance.
See #659 for a change doing the same for the
lib/pqdatabase driver, and #583 for MySQL.Tests verified locally with:
make test-short DATABASE='pgx pgx5'