Provide better error handling and error response parsing#13
Merged
gonzalezreal merged 1 commit intomasterfrom Jul 17, 2020
Merged
Provide better error handling and error response parsing#13gonzalezreal merged 1 commit intomasterfrom
gonzalezreal merged 1 commit intomasterfrom
Conversation
Owner
Author
|
README needs to be updated with the new changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides better error handling, by unifying all possible errors in an single type
APIClientError.On top of that, it provides the means to specify a type for the error response on each endpoint, as suggested in #8.
Additionally, this PR introduces a few changes in the
Endpointtype to let users of the library completely customise the decoding of responses and error responses, as suggested in #9.Thanks @kevinrenskers for the feedback.