Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(comment): malicious user cannot obtain another user’s session #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(comment): malicious user cannot obtain another user’s session #1959

wants to merge 2 commits into from

Conversation

mthorme
Copy link

@mthorme mthorme commented Jul 14, 2025

What

Fix misleading comment.

- # Make sure a malicious user can obtain a session and events not belonging to them
+ # Make sure a malicious user **cannot** obtain a session or events not belonging to them

Why

The previous wording contradicted the assertion assert len(session_mismatch.events) == 0, which verifies that a malicious user cannot access another user’s session or events.

Testing plan

Docs-only change.

@wyf7107 wyf7107 added the ready to pull [Admin] This PR is ready to be importing back to Google label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyf7107 wyf7107 wyf7107 approved these changes

Assignees
No one assigned
Labels
ready to pull [Admin] This PR is ready to be importing back to Google
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mthorme @wyf7107