fix: litellm tool serialization #2020
Merged
+84
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanzhou1023
approved these changes
Jul 18, 2025
|
thanks for the fix :) |
seanzhou1023
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported on #929
When serializing tools with a deep level of nesting, it was leaving behind some attributes, causing issues like
Invalid schema for function 'search_shop_catalog': 'STRING' is not valid under any of the given schemas.This PR does a small refactor on the
_schema_to_dictfunction adding support for that.The core issue was that after calling
model_dump, there's no longer an entry of typetypes.Schema, so the logic insidepropertieswas not being able to serialize the dict there.I've also added one extra test for this specific scenario so we have coverage there too.