fix(cli): Disable auto-reload feature on Windows system #415
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue caused by the auto-reload feature when running the CLI tool on Windows system. By detecting the operating system type, the auto-reload is disabled on Windows system to avoid potential errors: When mcp is asynchronously loaded, it will enter the _make_subprocess_transport NotImplementedError logic due to uvicorn reload=True in fastapi.
|
Thanks for the fix @nneverwei ! I'd suggest we add an option in the CLI to enable or disable the reload feature. So users(esp. windows) users can disable this if they come across this bug. |
7589655 to
d348f19
Compare
…users(esp. windows) can disable this if they come across the '_make_subprocess_transport NotImplementedError' bug on windows.
|
👍nice |
|
it might be useful to check if the platform is windows (os.name or sys.platform) and set the default for reload dynamically based on that. |
hangfei
approved these changes
May 8, 2025
|
Thanks for the addition! |
|
Could someone help update the documentation(https://github.com/google/adk-docs) on not to reoload for windows? |
copybara-service bot
pushed a commit
that referenced
this pull request
May 8, 2025
Copybara import of the project: -- a4a998d by 魏超 <[email protected]>: fix(cli): Disable auto-reload feature on Windows system Fixed the issue caused by the auto-reload feature when running the CLI tool on Windows system. By detecting the operating system type, the auto-reload is disabled on Windows system to avoid potential errors: When mcp is asynchronously loaded, it will enter the _make_subprocess_transport NotImplementedError logic due to uvicorn reload=True in fastapi. -- 46c9bb6 by 魏超 <[email protected]>: add an option in the CLI to enable or disable the reload feature. So users(esp. windows) can disable this if they come across the '_make_subprocess_transport NotImplementedError' bug on windows. COPYBARA_INTEGRATE_REVIEW=#415 from nneverwei:win-subprocess-NotImplError-with-mcp fbb9ab0 PiperOrigin-RevId: 756360981
nneverwei
added a commit
to nneverwei/adk-docs
that referenced
this pull request
May 13, 2025
…e. So users(esp. windows) can disable this if they come across the '_make_subprocess_transport NotImplementedError' bug on windows. [issue-#414](google/adk-python#414) [pull-#415](google/adk-python#415)
This was referenced May 13, 2025
|
|
merged in 85ccacb. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue caused by the auto-reload feature when running the CLI tool on Windows system. By detecting the operating system type, the auto-reload is disabled on Windows system to avoid potential errors: When mcp is asynchronously loaded, it will enter the _make_subprocess_transport NotImplementedError logic due to uvicorn reload=True in fastapi.
Although disabling the reload feature of uvicorn on Windows may result in some loss of functionality, as of now, MCP has large-scale usage scenarios, and it should be prioritized to ensure that MCP can be used normally
issue-#414
issue-#387