fix: support path level parameters for open_api_spec_parser #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
48b969b to
777a292
Compare
777a292 to
34b0012
Compare
|
Hi @hangfei and @seanzhou1023 , i've fixed the unittest accordingly. |
|
Hi maintainers, just checking in on this PR. Let me know if any changes are needed or if there's anything I can do to help move it forward. Thanks! |
|
@seanzhou1023 Could you help review this change? |
seanzhou1023
approved these changes
Jul 18, 2025
|
lgtm, thanks for the fix :) |
autoformat the changes
seanzhou1023
approved these changes
Jul 18, 2025
seanzhou1023
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support of path level parameters in open_api_spec_parser as defined in the OpenAPI spec.
Ref: https://swagger.io/docs/specification/v3_0/describing-parameters/#common-parameters
This PR aimed in fixes #540 (*detailed problem description)
What this PR does
Proof that it works