feat: Add S3 support for artifacts #556
Open
+7,304
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torage client for improved testability; update tests to cover S3
I didn't see your PR, I opened a discussion about that. Are you done with it? Why it isn't merged yet? |
Axibord
reviewed
May 15, 2025
Comment on lines
+19
to
+30
| def __init__(self, bucket_name: str,s3_client: Optional[BaseClient], **kwargs): | ||
| """Initializes the S3ArtifactService. | ||
|
|
||
| Args: | ||
| bucket_name: The name of the S3 bucket to use. | ||
| **kwargs: Optional parameters for boto3 client configuration. | ||
| """ | ||
| self.bucket_name = bucket_name | ||
| if s3_client is None: | ||
| self.s3 = boto3.client("s3", **kwargs) | ||
| else: | ||
| self.s3 = s3_client |
There was a problem hiding this comment.
Why are we giving the choice to not pass an S3 client directly but use **kwargs ? I think enforcing it is better.
|
Hi @samueljohnsiby thanks for implementing this PR. I am very interested in S3 compatibility. Do you plan to continue working on this? Given that you have already gotten the vast majority of functionality in here, I volunteer to take this forward for the last mile if you are otherwise occupied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added s3 support to manage artifacts using boto3. Written tests for the same under test artifact service file.
resolves : #555