-
Notifications
You must be signed in to change notification settings - Fork 26
add optional dependencies per utility #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,12 +25,10 @@ classifiers = [ # List of https://pypi.org/classifiers/ | |
| ] | ||
| dependencies = [ | ||
| # go/keep-sorted start | ||
| "google-genai>=1.21.1, <2.0.0", # Google GenAI SDK | ||
| "google-adk", # Google ADK | ||
| "httpx>=0.27.0, <1.0.0", # For OpenMemory service | ||
| "redis>=5.0.0, <6.0.0", # Redis for session storage | ||
| # go/keep-sorted end | ||
| "google-genai>=1.21.1, <2.0.0", # Google GenAI SDK | ||
| "orjson>=3.11.3", | ||
| # go/keep-sorted end | ||
| ] | ||
| dynamic = ["version"] | ||
|
|
||
|
|
@@ -41,9 +39,23 @@ changelog = "https://github.com/google/adk-python-community/blob/main/CHANGELOG. | |
| documentation = "https://google.github.io/adk-docs/" | ||
|
|
||
| [project.optional-dependencies] | ||
| firestore = [ | ||
| "google-cloud-firestore", # Firestore client library | ||
| ] | ||
| redis = [ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Making |
||
| "redis>=5.0.0, <6.0.0", # Redis for session storage | ||
| ] | ||
| openmemory = [ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Making |
||
| "httpx>=0.27.0, <1.0.0", # For OpenMemory service | ||
| ] | ||
| all = [ | ||
| "google-cloud-firestore", # Firestore client library | ||
| "httpx>=0.27.0, <1.0.0", # For OpenMemory service | ||
| "redis>=5.0.0, <6.0.0", # Redis for session storage | ||
| ] | ||
| test = [ | ||
| "pytest>=8.4.2", | ||
| "pytest-asyncio>=1.2.0", | ||
| "pytest>=8.4.2", | ||
| "pytest-asyncio>=1.2.0", | ||
| ] | ||
|
|
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding
google-cloud-firestoreas an optional dependency is a good step, please ensure that the corresponding utility that uses it handles theImportErrorgracefully if the dependency is not installed. This is to prevent runtime errors for users who do not install the[firestore]extra. Based on other files in this library, it's likely this check is missing.