Make dependency on rust-fuzzy-search optional (#197) #199
Conversation
Updates the lib and tests to make the dependency on rust-fuzzy-search optional, allowing for smaller binaries if the feature is not needed. Fixes: google#197
| argh_shared.workspace = true | ||
| argh_derive.workspace = true | ||
| rust-fuzzy-search = "0.1.1" | ||
| rust-fuzzy-search = { version = "0.1.1", optional = true } |
There was a problem hiding this comment.
Should we make this feature on by default? While I'm not sure if it should have been on by default in the first place, but now it's in a released version it'd be somewhat of a breaking change to remove it. We can then easily opt out of it on Fuchsia.
There was a problem hiding this comment.
Most certainly an argument can be made for either choice. My personal opinion is that this is a nice-to-have functionality that should have been optional in the first place. Changing it to optional may require few downstream users to update their build config, but this is literally the most benign form of a breaking change. No code change is needed, just setting the cargo flag. IMO the change to optional is taking the early opportunity to correct the original oversight.
Updates the lib and tests to make the dependency on rust-fuzzy-search optional, allowing for smaller binaries if the feature is not needed.
Fixes: #197