Eliminate usage of deprecated API in sysinfo.cc #1474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `std::wstring_convert` is deprecated in C++17. Since this code is in the windows branch, we could use the win32 API (MultiByteToWideChar)
|
can you take a look at the lint issue please? |
|
Fixed the lint issue. PTAL. Thanks! |
dmah42
approved these changes
Aug 30, 2022
|
thanks |
dmah42
pushed a commit
that referenced
this pull request
Sep 14, 2022
* Eliminate usage of deprecated API in sysinfo.cc The `std::wstring_convert` is deprecated in C++17. Since this code is in the windows branch, we could use the win32 API (MultiByteToWideChar) * ran clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
std::wstring_convertis deprecated in C++17 (without alternative).Since this code is in the windows branch, we could use the win32 API (MultiByteToWideChar)