reenable msan sanitizer workflow #1589

dmah42 · 2023-04-27T08:27:11Z

No description provided.

LebedevRI · 2023-04-27T11:31:59Z

Yup, i do not see where you custom-build libc++. That is really necessary for MSan.
Roughly, you need

$ git clone --depth=1 https://github.com/llvm/llvm-project
$ mkdir <llvm-build> && cd <llvm-build>
$ cmake -GNinja ../llvm-project/runtimes/ -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_USE_SANITIZER=MemoryWithOrigins
$ ninja cxx cxxabi unwind
$ cd benchmark-build-dir
$ CC=clang CXX=clang++ CXXFLAGS="-fsanitize=memory -fsanitize-memory-track-origins -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -stdlib=libc++ -L<llvm-build>/lib -lc++abi -Isystem<llvm-build>/include -Isystem<llvm-build>/include/c++/v1 -Wl,-rpath,<llvm-build>/lib" cmake <...> ..

dmah42 · 2023-04-27T11:58:52Z

something like https://github.com/google/benchmark/blob/main/.github/libcxx-setup.sh ?

we used to have this, but with it the sanitizer workflow timed out because the libc++ build is way too slow. maybe it's worth trying just for msan.

LebedevRI · 2023-04-27T12:04:12Z

something like https://github.com/google/benchmark/blob/main/.github/libcxx-setup.sh ?

Close, but my snippet is the more modern version of that incantation.

we used to have this, but with it the sanitizer workflow timed out because the libc++ build is way too slow. maybe it's worth trying just for msan.

Unless the whole LLVM gets built accidentally, i don't believe that should be slow at all, maybe 10 extra minutes.

dmah42 · 2023-04-27T13:11:58Z

note: LLVM build is at 30% after 12m.

dmah42 · 2023-04-27T13:13:13Z

msan debug failure is the same as when we didn't build libc++ with msan (unless i messed up the linking somehow)

LebedevRI · 2023-04-27T13:37:29Z

.github/libcxx-setup.sh

-#make -C llvm-build -j3 cxx cxxabi
-#sudo make -C llvm-build install-cxx install-cxxabi
-#cd ..
+cd ./llvm-project


cd ./llvm-project/runtimes/

LebedevRI · 2023-04-27T13:40:33Z

msan debug failure is the same as when we didn't build libc++ with msan (unless i messed up the linking somehow)

You have noticed that the libc++ build itself failed, right?

dmah42 · 2023-04-27T16:03:14Z

msan debug failure is the same as when we didn't build libc++ with msan (unless i messed up the linking somehow)

You have noticed that the libc++ build itself failed, right?

gah, no i didn't. i guess the script should return an error status.

LebedevRI · 2023-04-27T16:10:07Z

.github/libcxx-setup.sh

 # Checkout LLVM sources
-#git clone --depth=1 https://github.com/llvm/llvm-project.git llvm-project
-#
+git clone --depth=1 https://github.com/llvm/llvm-project.git llvm-project


One more thing to note, it is rather issue-prone to use libc++ from trunk,
e.g. because nowadays they only guarantee building libc++ with clang
from the same revision or so, so building with older clang may fail,
and i'm not sure that will be caught at cmake time.
So it would be best to checkout some specific tag.

LebedevRI · 2023-04-27T16:12:06Z

.github/libcxx-setup.sh

+      -DLLVM_USE_SANITIZER=${LIBCXX_SANITIZER}  \
+      -DLLVM_BUILD_32_BITS=${BUILD_32_BITS}     \
+      -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi;libunwind' \
+      -S llvm -B llvm-build -G "Unix Makefiles"


Right, i guess it's -S . now.

yep. working on it. can't test locally so i'm iterating here :(

dmah42 · 2023-04-27T16:22:06Z

ok it builds much faster (yay) but still fails with the same error in sysinfo.

LebedevRI · 2023-04-27T16:43:03Z

ok it builds much faster (yay) but still fails with the same error in sysinfo.

Nice!
I'd suggest to drop the install stuff, and explicitly add -stdlib=libc++ -L<llvm-build>/lib -lc++abi -Isystem<llvm-build>/include -Isystem<llvm-build>/include/c++/v1 -Wl,-rpath,<llvm-build>/lib to CXXFLAGS.

dmah42 · 2023-04-28T10:53:09Z

welp. msan passes, now asan is failing. it looks like an odr violation in libcxx so i tried suppression but failed. concerned that it is odr violation but coming from something in our code (the output tests maybe?)

LebedevRI · 2023-04-28T11:46:25Z

Could you try passing -DBUILD_SHARED_LIBS=OFF (!) for sanitizer build jobs?

LebedevRI · 2023-04-28T12:50:34Z

.github/workflows/sanitizer.yml

      run: |
        "${GITHUB_WORKSPACE}/.github/libcxx-setup.sh"
-        echo "EXTRA_CXX_FLAGS=\"-stdlib=libc++\"" >> $GITHUB_ENV
+        echo "EXTRA_CXX_FLAGS=-stdlib=libc++ -L ${GITHUB_WORKSPACE}/llvm-build/lib -lc++abi -Isystem${GITHUB_WORKSPACE}/llvm-build/include -Isystem${GITHUB_WORKSPACE}/llvm-build/include/c++/v1 -Wl,-rpath,${GITHUB_WORKSPACE}/llvm-build/lib" >> $GITHUB_ENV


Ok, last guess:
Prepend -nostdlibc++ before -stdlib=libc++ here.

LebedevRI · 2023-04-28T16:27:28Z

.github/workflows/sanitizer.yml

      run: |
        "${GITHUB_WORKSPACE}/.github/libcxx-setup.sh"
-        echo "EXTRA_CXX_FLAGS=\"-stdlib=libc++\"" >> $GITHUB_ENV
+        echo "EXTRA_CXX_FLAGS=-nostdlibc++ -stdlib=libc++ -L ${GITHUB_WORKSPACE}/llvm-build/lib -lc++abi -Isystem${GITHUB_WORKSPACE}/llvm-build/include -Isystem${GITHUB_WORKSPACE}/llvm-build/include/c++/v1 -Wl,-rpath,${GITHUB_WORKSPACE}/llvm-build/lib" >> $GITHUB_ENV


Err, i guess it's apparently -nostdlib++, without the c letter.
Also, are you sure about the space after -L?

LebedevRI · 2023-04-28T16:28:17Z

Ok, final guess: add -fsanitize-address-use-odr-indicator to global CXXFLAGS, when building both the libc++ and benchmark.

LebedevRI · 2023-04-28T16:30:51Z

@dmah42 sorry for so much back-n-forth here.

dmah42 · 2023-04-28T18:24:48Z

@dmah42 sorry for so much back-n-forth here.

no problem. I'm at a loss so I'm happy for guidance.

LebedevRI · 2023-05-02T13:11:19Z

Ok, final guess: add -fsanitize-address-use-odr-indicator to global CXXFLAGS, when building both the libc++ and benchmark.

LebedevRI · 2023-05-03T11:58:31Z

.github/workflows/sanitizer.yml

@@ -23,7 +23,7 @@ jobs:
    - name: configure msan env
      if: matrix.sanitizer == 'msan'
      run: |
-        echo "EXTRA_FLAGS=-g -O2 -fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins" >> $GITHUB_ENV
+        echo "EXTRA_FLAGS=-g -O2 -fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins -fsanitize-address-use-odr-indicator" >> $GITHUB_ENV


It should be for if: matrix.sanitizer == 'asan' block, though

ugh. i forgot what i was doing over the weekend. sorry.

this is the default for non-windows so i can drop it anyway

LebedevRI · 2023-05-03T12:40:56Z

I see. Do we really need to custom-build libc++ for non-msan? Because that isn't really necessary.
Can we just not do that instead?

dmah42 · 2023-05-03T12:46:30Z

I see. Do we really need to custom-build libc++ for non-msan? Because that isn't really necessary. Can we just not do that instead?

they're all passing in the current state.. maybe just don't use the custom libc++ for asan (as it seems to have the issue)? or find the way to suppress the warning correctly.

LebedevRI · 2023-05-03T13:08:07Z

I see. Do we really need to custom-build libc++ for non-msan? Because that isn't really necessary. Can we just not do that instead?

they're all passing in the current state.. maybe just don't use the custom libc++ for asan (as it seems to have the issue)? or find the way to suppress the warning correctly.

That's what i'm suggesting, yes.

.github/workflows/sanitizer.yml

LebedevRI

Yay, ship it! (probably should be squash-merged)
Thank you.

dmah42 · 2023-05-03T15:55:52Z

thanks for all the help!

reenable msan sanitizer workflow

7743808

dmah42 mentioned this pull request Apr 27, 2023

Remove not needed msan implementation from workflows #1587

Closed

dmah42 added 2 commits April 27, 2023 13:54

re-enable libcxx build for sanitizer workflow

ccac0de

exclude msan+gcc combination

c64866a

LebedevRI reviewed Apr 27, 2023

View reviewed changes

llvm path fix and return error on failure

013d5d6

LebedevRI reviewed Apr 27, 2023

View reviewed changes

fix libcxx script paths

cde1b61

dmah42 added 7 commits April 28, 2023 10:11

don't install, just use

af7cdd2

where are these things being built to...

59112ee

only clang

328c1ee

github workspace for root

aeefb1e

spaces matter?

989a00d

suppress asan errors from libcxx

6fe4f51

don't suppress libcxx, just suppress odr-violation

dd73888

static linking

adbdb7f

LebedevRI reviewed Apr 28, 2023

View reviewed changes

nostdlibc++, only libc++

0c09a80

LebedevRI reviewed Apr 28, 2023

View reviewed changes

spell nostdlib right

4ab41e6

dmah42 added 2 commits May 3, 2023 12:53

try sanitize-address-use-odr-indicator

e966401

disable odr checking

76e4b3b

LebedevRI reviewed May 3, 2023

View reviewed changes

dmah42 added 4 commits May 3, 2023 13:01

the space was important?

2940590

revert a few things. back to simpler times

224a253

nostdlib for libcxx _and_ benchmark

c13ab5e

bring back stdlib i guess

9d5dad0

trying some odr violation tweaks

3f0e008

disable libcxx for asan

b556916

dmah42 marked this pull request as ready for review May 3, 2023 13:25

LebedevRI reviewed May 3, 2023

View reviewed changes

.github/workflows/sanitizer.yml Outdated Show resolved Hide resolved

LebedevRI previously approved these changes May 3, 2023

View reviewed changes

don't need shared libs

67eae6e

dmah42 dismissed LebedevRI’s stale review via 67eae6e May 3, 2023 15:06

LebedevRI approved these changes May 3, 2023

View reviewed changes

dmah42 merged commit fba5dd1 into main May 3, 2023

dmah42 deleted the msan branch May 3, 2023 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reenable msan sanitizer workflow #1589

reenable msan sanitizer workflow #1589

dmah42 commented Apr 27, 2023

LebedevRI commented Apr 27, 2023

dmah42 commented Apr 27, 2023

LebedevRI commented Apr 27, 2023

dmah42 commented Apr 27, 2023

dmah42 commented Apr 27, 2023

LebedevRI Apr 27, 2023

LebedevRI commented Apr 27, 2023

dmah42 commented Apr 27, 2023

LebedevRI Apr 27, 2023

LebedevRI Apr 27, 2023

dmah42 Apr 27, 2023

dmah42 commented Apr 27, 2023

LebedevRI commented Apr 27, 2023

dmah42 commented Apr 28, 2023

LebedevRI commented Apr 28, 2023

LebedevRI Apr 28, 2023

LebedevRI Apr 28, 2023

LebedevRI commented Apr 28, 2023

LebedevRI commented Apr 28, 2023

dmah42 commented Apr 28, 2023

LebedevRI commented May 2, 2023

LebedevRI May 3, 2023

dmah42 May 3, 2023

dmah42 May 3, 2023

LebedevRI commented May 3, 2023

dmah42 commented May 3, 2023

LebedevRI commented May 3, 2023

LebedevRI left a comment

dmah42 commented May 3, 2023

reenable msan sanitizer workflow #1589

reenable msan sanitizer workflow #1589

Conversation

dmah42 commented Apr 27, 2023

LebedevRI commented Apr 27, 2023

dmah42 commented Apr 27, 2023

LebedevRI commented Apr 27, 2023

dmah42 commented Apr 27, 2023

dmah42 commented Apr 27, 2023

Choose a reason for hiding this comment

LebedevRI commented Apr 27, 2023

dmah42 commented Apr 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmah42 commented Apr 27, 2023

LebedevRI commented Apr 27, 2023

dmah42 commented Apr 28, 2023

LebedevRI commented Apr 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LebedevRI commented Apr 28, 2023

LebedevRI commented Apr 28, 2023

dmah42 commented Apr 28, 2023

LebedevRI commented May 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LebedevRI commented May 3, 2023

dmah42 commented May 3, 2023

LebedevRI commented May 3, 2023

LebedevRI left a comment

Choose a reason for hiding this comment

dmah42 commented May 3, 2023