Add pyproject.toml file for PEP518 compliance #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmah42
reviewed
Jul 10, 2023
pyproject.toml
Outdated
| keywords = ["benchmark"] | ||
|
|
||
| authors = [ | ||
| {name = "Google", email = "[email protected]"}, |
There was a problem hiding this comment.
why isn't this the existing benchmark discussion group?
There was a problem hiding this comment.
This is meant to be more of a direct point of contact to the "authors" specifically, and it needs to be an email address.
There was a problem hiding this comment.
Updated the email in 7fdfc46.
dmah42
reviewed
Jul 10, 2023
dmah42
reviewed
Jul 10, 2023
The newly created `pyproject.toml` contains all static metadata as well as the readme and version as dynamic arguments, to be read by setuptools during the build. What is left in the `setup.py` for now is the custom Bazel extension class, since that is not properly supported yet.
e2de958 to
7fdfc46
Compare
dmah42
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly created
pyproject.tomlcontains all static metadata as well as the readme and version as dynamic arguments, to be read by setuptools during the build.What is left in the
setup.pyfor now is the custom Bazel extension class, since that is not properly supported yet.Part of #1583.