Delete unused requirements file, simplify nanobind build file #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependencies are contained in the `pyproject.toml` since it was added. Switches to header and source file globbing instead of manually listing the files. The selects for different platforms are removed, as a tradeoff, we take a single- to low double-digit hit in wheel sizes (between 5 percent zipped and 12% installed on MacOS 13.4).
dmah42
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies are contained in the
pyproject.tomlsince it was added.Switches to header and source file globbing instead of manually listing the files. The selects for different platforms are removed, as a tradeoff, we take a single- to low double-digit hit in wheel sizes (between 5 percent zipped and 12% installed on MacOS 13.4).
The linker response file approach can (in my opinion) be revisited once bazelbuild/bazel#18952 is through.