Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Python 3.12 support #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Add Python 3.12 support #1676

merged 4 commits into from
Oct 23, 2023

Conversation

nicholasjng
Copy link
Contributor

These commits contain a few changes:

  • nanobind bump to v1.6.2 (Sep 2023). (0a816f0)
  • GitHub Actions checkout to v4, reset to windows-latest as Windows runner image. (609415e)
  • Python 3.12 wheel builds via cibuildwheel version bump and envvar change. (609415e)
  • The move to trusted publishing for PyPI wheel releases. (609415e)

Related: I am currently working on a project using setuptools_scm as an addition in the build step, which makes manual version bumping for the Python bindings unnecessary (the package parses the new version out of a tag name created e.g. by a GitHub release), in case there is interest in opting into that.

dmah42
dmah42 previously approved these changes Oct 10, 2023
… builds

Trusted publishing has been available since v1.8.0 of the pypa-publish
action. It enables password-less authentication and wheel uploads from
the wheel upload job.

`cibuildwheel` was bumped to v2.16.2 to allow Python 3.12 wheel builds.

More info on trusted publishing:
https://github.com/marketplace/actions/pypi-publish#trusted-publishing

The Windows distribution was reverted to `latest` in the OS matrix,
since the discovery problem of MSVC was fixed in a Bazel patch release.
@nicholasjng
Copy link
Contributor Author

Rebased on main, bumped nanobind to stable v1.7.0, which was released in the meantime.

@nicholasjng nicholasjng requested a review from dmah42 October 23, 2023 11:25
@dmah42 dmah42 merged commit 5893034 into google:main Oct 23, 2023
@nicholasjng nicholasjng deleted the python312-support branch April 15, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants