Thanks to visit codestin.com
Credit goes to github.com

Skip to content

README.md: fix build instructions #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

0dminnimda
Copy link
Contributor

No description provided.

@dmah42
Copy link
Member

dmah42 commented Nov 21, 2024

i wonder if we should do the opposite.

if a user has the googletest libraries installed on their machine then they do not need to download the dependencies. if it was the case, then we would just make this the default. as such, the instructions should probably elide the downloading of dependencies for both cases (old cmake and new).

further, as we now require cmake 3.13, the older form can be removed from the documentation entirely.

@0dminnimda
Copy link
Contributor Author

Yep, reusing installed libraries would be preferred to downloading and building them specifically for this project. Though right now you can really quickly start using the project, no need to install libraries separately, which is very useful.

@dmah42 dmah42 merged commit f981f58 into google:main Jan 8, 2025
1 check passed
@dmah42
Copy link
Member

dmah42 commented Jan 8, 2025

thank you!

@0dminnimda 0dminnimda deleted the fix_readme_build_instructions branch January 8, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants