remove cxx03 test, fully unblocking c++1X development #1903
Conversation
96c291d to
4f85a1f
Compare
|
@LebedevRI i'd appreciate your thoughts on taking this step. i think it's time, but i'm not entirely comfortable making the decision unilaterally. |
FWIW, i'm only now starting to actually look at github notifications, or read incoming mail. |
There was a problem hiding this comment.
Could you please drop the enum changes (outside of test/) from this PR, i.e., do explicitly specify the underlying type, which i guess is int, and do the type narrowing in a follow-up PR?
Latter may or may not have ABI implications and should be more explicit.
https://godbolt.org/z/d46eGcsoj
|
i'm happy to, but how would we test the ABI implications in that other PR? i'm not seeing how splitting it is going to make it any safer, unless you just want something to more easily roll back? |
|
done |
Without that change, this PR is rather no-changes-intended and is easy to review. |
|
well, we will do it, because the whole point is to get clang-tidy to stop complaining :) |
| @@ -84,7 +84,7 @@ | |||
| namespace benchmark { | |||
| namespace { | |||
|
|
|||
| void PrintImp(std::ostream& out) { out << std::endl; } | |||
| void PrintImp(std::ostream& out) { out << '\n'; } | |||
There was a problem hiding this comment.
Should we flush stream[s] before calling std::exit(), since it does not do that automatically?
There was a problem hiding this comment.
adding to everywhere we explicitly exit
There was a problem hiding this comment.
There's probably other places where we might flush intentionally, but this is better than nothing.
| @@ -544,8 +506,7 @@ inline BENCHMARK_ALWAYS_INLINE void DoNotOptimize(Tp&& value) { | |||
| asm volatile("" : "+m,r"(value) : : "memory"); | |||
| #endif | |||
| } | |||
| #endif | |||
| #elif defined(BENCHMARK_HAS_CXX11) && (__GNUC__ >= 5) | |||
| #elif (__GNUC__ >= 5) | |||
There was a problem hiding this comment.
This needs a comment. It took me a while to get that it is for #if !defined(__GNUC__) || defined(__llvm__) || defined(__INTEL_COMPILER)
There was a problem hiding this comment.
it took me ages to navigate these ifdefs too. added comments.
test/output_test_helper.cc
Outdated
| std::cerr << "Failed to create unique temporary file name\n"; | ||
| std::abort(); |
There was a problem hiding this comment.
(Abort is same as exit)
| @@ -57,7 +57,7 @@ class CheckHandler { | |||
| #pragma warning(disable : 4722) | |||
| #endif | |||
| BENCHMARK_NORETURN ~CheckHandler() BENCHMARK_NOEXCEPT_OP(false) { | |||
There was a problem hiding this comment.
Should this/CallAbortHandler flush?
There was a problem hiding this comment.
nice.. we have too many exit points :P
|
sorry @LebedevRI i wiped your approval by merging and adding more flushes. |
(No, it literally ate a whole comment. Maybe it happened to get posted the moment you pushed.) |
removing cxx03_test allows us to use c++1X features in headers and thus clean up a bunch of clang-tidy warnings too.
after this i'll tackle the sanitizer and windows/clang32 CI bots.