Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Lightweight observable evaluation #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

Lightweight observable evaluation #1151

merged 2 commits into from
Apr 8, 2025

Conversation

TristonianJones
Copy link
Collaborator

Transitions from replanning expressions on each invocation to generating
stateful metadata in a concurrency friendly manner. Offers a 2-4x speedup
over the previous method.

Before:

BenchmarkEvalOptions/optimize-12         	 2753293	       571.3 ns/op	      32 B/op	       2 allocs/op
BenchmarkEvalOptions/track-state-12      	  170517	      6829 ns/op	    1729 B/op	      42 allocs/op
BenchmarkEvalOptions/exhaustive-eval-12  	  127220	      8569 ns/op	    1785 B/op	      44 allocs/op

After:

BenchmarkEvalOptions/optimize-12         	 3305553	       526.5 ns/op	      32 B/op	       2 allocs/op
BenchmarkEvalOptions/track-state-12      	  595286	      1957 ns/op	     368 B/op	       8 allocs/op
BenchmarkEvalOptions/exhaustive-eval-12  	  578535	      2251 ns/op	     368 B/op	       8 allocs/op

@TristonianJones
Lightweight observable evaluation
7c01e86 
Transitions from replanning expressions on each invocation to
generating stateful metadata in a concurrency friendly manner
@TristonianJones
Copy link
Collaborator Author

@jpbetz FYI

@TristonianJones TristonianJones requested a review from jcking April 3, 2025 00:57
@jpbetz
Copy link
Contributor

jpbetz commented Apr 3, 2025

LGTM

I reviewed the change to the planner and that looks how I'd hoped. Bench numbers look really good.

@TristonianJones TristonianJones merged commit 2c79b14 into google:master Apr 8, 2025
2 checks passed
@TristonianJones TristonianJones deleted the state-tracker-opt branch April 8, 2025 19:08
This was referenced Apr 23, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcking jcking jcking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TristonianJones @jpbetz @jcking