[Logging] Truncate extras values #4759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb2c035 to
6c187b5
Compare
| # This extras field is needed because the call | ||
| # getattr(record, 'extras', {}) returns None and not the | ||
| # default for the case of running against a mock | ||
| extras={"test": "1"}, |
There was a problem hiding this comment.
Maybe a better workaround would be extras={}?
There was a problem hiding this comment.
Just because the test being called test_no_extras and having extras is kind of misleading.
There was a problem hiding this comment.
Yep, to avoid misunderstanding, I said your suggestion works too, and then I applied it. Thanks for it!
Signed-off-by: Javan Lacerda <[email protected]>
Signed-off-by: Javan Lacerda <[email protected]>
340bcec to
3ce5291
Compare
ViniciustCosta
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It truncates the extras value for logging, as it can be used to log full exception stacktracing, blowing our log size threshold.