[Logging] Add logs context to Fuzz Task #4777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanlacerda
reviewed
May 2, 2025
| @@ -2060,6 +2068,8 @@ def utask_preprocess(fuzzer_name, job_type, uworker_env): | |||
| fuzz_target = _preprocess_get_fuzz_target(fuzzer_name, job_type) | |||
| fuzz_task_input = uworker_msg_pb2.FuzzTaskInput() # pylint: disable=no-member | |||
| if fuzz_target: | |||
| # Add the chosen fuzz target to logs context. | |||
| logs.log_contexts.add_metadata('fuzz_target', fuzz_target.binary) | |||
There was a problem hiding this comment.
Should we do the tear down for this?
There was a problem hiding this comment.
This is already handled by the fuzzer log context that is wrapping the function call (here). So this is essentially updating this metadata, not adding it.
javanlacerda
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds structured logging to the fuzz task by instrumenting it with the fuzzing-related logs context.
Notes that for preprocess, the fuzz target is set to None until it is is picked.
Tests
Onebox deployment to internal (chrome) GCE instance (link to logs):
Stage - Preprocess:
Stage - Main:
