[Logging] Create and add structured logs for Cleanup task #4781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +60,11 @@ def main(): | |||
| task = sys.argv[1] | |||
|
|
|||
| task_module_name = f'clusterfuzz._internal.cron.{task}' | |||
|
|
|||
There was a problem hiding this comment.
Can we make a standard function to do this rather than reimplementing it?
There was a problem hiding this comment.
Done, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding structured logging to the cleanup cronjob. In order to enable this, the following changes on logs module were done:
extrasargument from python logging to thejson_fieldsmetadata in google cloud logging (GCP reference). (Note that this is a workaround to enable the observability project for now. As a long-term solution, we should try to centralize the logs handlers/filters for all environments).For the cleanup module:
Tests
Running the cronjob locally with the debugger and sending logs to GCP.
IS_K8S_ENVto true (link to logs):