WIP: Add flatbuffer_cc library support #4861
Closed
+333
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardappel
reviewed
Aug 9, 2018
Collaborator
aardappel
left a comment
There was a problem hiding this comment.
I can't vouch for the Bazel changes, but I assume you know what you're doing :)
| @@ -0,0 +1,65 @@ | |||
| #include "flatbuffers/flexbuffers.h" | |||
Collaborator
There was a problem hiding this comment.
this file is weird to me. It doesn't actually test anything, and has a bunch of unused code. Can it be cleaned up? removed? replaced with just using test.cpp?
Merged
Contributor
|
https://github.com/AustinSchuh/flatbuffers/tree/flatbuffer_cc has the changes required to make all the tests pass. Is there any way I can help finish this? We use bazel and I'm looking at using flatbuffers and would rather start with no local modifications :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the whole repository now works after adding support for the
io_bazel_rules_go.Testing the whole repo fails with this, but that won't block this CL:
The
flatbuffers_cc_libraryis a mostly identical port from the internal rules. I attempted to add a C++ test that depends on themonster_test.fbsthrough theflatbuffer_cc_libraryrule. Currently, it fails with:I'm not sure why the enum already exists error is thrown.