Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add default NaN/Inf to C#, Java, Python #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aardappel merged 3 commits into from
Jan 14, 2019
Merged

Add default NaN/Inf to C#, Java, Python #5107

aardappel merged 3 commits into from
Jan 14, 2019

Conversation

@vglavnyy
Copy link
Contributor

@vglavnyy vglavnyy commented Jan 8, 2019

This PR extend support of default NaN and Inf values (#5102).
These default numbers can be added to other languages using SimpleFloatConstantGenerator (Pyhton) and TypedFloatConstantGenerator (C++, C#).

@vglavnyy vglavnyy force-pushed the def_nan_csharp_java branch 2 times, most recently from 9435fe6 to 5224bf5 Compare January 8, 2019 10:28
@vglavnyy vglavnyy force-pushed the def_nan_csharp_java branch from 19af105 to 9c2598a Compare January 8, 2019 14:29
@rw
Copy link
Contributor

rw commented Jan 8, 2019

@vglavnyy Would you please add Python tests for this?

@vglavnyy
Copy link
Contributor Author

vglavnyy commented Jan 9, 2019

@rw Added.
I'm not familiar with the requirements of python tests.
Code formatting and style may be broken.
Need to fix something?

@vglavnyy vglavnyy force-pushed the def_nan_csharp_java branch from 9bfe4d6 to 361f34a Compare January 9, 2019 13:14
@rw
Copy link
Contributor

rw commented Jan 10, 2019

@vglavnyy Python tests LGTM.

@rw
Copy link
Contributor

rw commented Jan 10, 2019 •
edited
Loading

@vglavnyy We probably need Java and C# tests too, although I don't know those codebases as well, so @aardappel would know better.

@vglavnyy
Copy link
Contributor Author

vglavnyy commented Jan 10, 2019

@rw С++, C#, Java are tested at compile time with include/import directives.
It is easy to add explicit checking for NaN/Inf in the C++.
Unfortunately, I have not an environment to compile C# and Java tests.

aardappel
aardappel reviewed Jan 10, 2019
View reviewed changes
Copy link
Collaborator

@aardappel aardappel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Yes, this looks sufficiently tested at compile time to me.

@vglavnyy vglavnyy force-pushed the def_nan_csharp_java branch from 8e21595 to 9c7c346 Compare January 11, 2019 15:43
@vglavnyy vglavnyy mentioned this pull request Jan 14, 2019
Closed
@aardappel
Copy link
Collaborator

aardappel commented Jan 14, 2019

Thanks!

@aardappel aardappel merged commit 4fa4d36 into google:master Jan 14, 2019
@vglavnyy vglavnyy deleted the def_nan_csharp_java branch January 20, 2019 15:40
zchee pushed a commit to zchee/flatbuffers that referenced this pull request Feb 14, 2019
@vglavnyy @zchee
Add default NaN/Inf to C#, Java, Python (google#5107)
3021304 
* Add default NaN/Inf to C#, Java, Python

* Python NaN/Inf test added

* Remove MSVC2010/13 dependent code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aardappel aardappel aardappel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vglavnyy @rw @aardappel