Fix high certainty warnings from PVS-studio #5115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced FLATBUFFERS_ATTRIBUTE macro to use [[attribute]] if modern C++ compiler used
aardappel
reviewed
Jan 14, 2019
Collaborator
aardappel
left a comment
There was a problem hiding this comment.
Nice! This seems to have caught some small but actual bugs, too!
include/flatbuffers/base.h
Outdated
| // Clang 3.4 and later implement all of the ISO C++ 2014 standard. | ||
| // http://clang.llvm.org/cxx_status.html | ||
|
|
||
| // MSVC note: requires `/Zc:__cplusplus` or use _MSVC_LANG |
Collaborator
There was a problem hiding this comment.
What are the consequences of this? I don't think we want to require our users to specify this flag for things to work correctly.
Collaborator
|
Ok, thanks! |
Collaborator
|
@vglavnyy can you email me? |
vglavnyy
added a commit
to vglavnyy/flatbuffers
that referenced
this pull request
Jan 26, 2019
- GCC: fixed broken `fallthrough` (checked with 7.3 and 8.2) - Clang: added `fallthrough` support - Clang: added `-Wimplicit-fallthrough` checking
vglavnyy
added a commit
to vglavnyy/flatbuffers
that referenced
this pull request
Jan 26, 2019
- GCC: fixed broken `fallthrough` (checked with 7.3 and 8.2) - Clang: added `fallthrough` support - Clang: added `-Wimplicit-fallthrough` checking
Merged
aardappel
pushed a commit
that referenced
this pull request
Jan 28, 2019
- GCC: fixed broken `fallthrough` (checked with 7.3 and 8.2) - Clang: added `fallthrough` support - Clang: added `-Wimplicit-fallthrough` checking
zchee
pushed a commit
to zchee/flatbuffers
that referenced
this pull request
Feb 14, 2019
* Fix high certainty warnings from PVS-studio - Introduced FLATBUFFERS_ATTRIBUTE macro to use [[attribute]] if modern C++ compiler used * Update the note about __cplusplus usage in the MSVC
zchee
pushed a commit
to zchee/flatbuffers
that referenced
this pull request
Feb 14, 2019
- GCC: fixed broken `fallthrough` (checked with 7.3 and 8.2) - Clang: added `fallthrough` support - Clang: added `-Wimplicit-fallthrough` checking
arcadia-devtools
pushed a commit
to catboost/catboost
that referenced
this pull request
Dec 21, 2020
It was replaced by size() in google/flatbuffers@96592d5d and deprecated in google/flatbuffers#5115 ref:a1bb5b6bb8e2d38b8332fe3b22818770cb60f9a4
arcadia-devtools
pushed a commit
to catboost/catboost
that referenced
this pull request
Jan 19, 2022
It was replaced by size() in google/flatbuffers@96592d5d and deprecated in google/flatbuffers#5115 ref:a1bb5b6bb8e2d38b8332fe3b22818770cb60f9a4
robot-piglet
pushed a commit
to catboost/catboost
that referenced
this pull request
Jan 15, 2023
It was replaced by size() in google/flatbuffers@96592d5d and deprecated in google/flatbuffers#5115 ref:a1bb5b6bb8e2d38b8332fe3b22818770cb60f9a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flatbuffers has checked with the PVS-studio static code analyzer.
This PR fixes several high certainty warnings and introduces
FLATBUFFERS_ATTRIBUTEmacro definition.The
FLATBUFFERS_ATTRIBUTEtemporary disabled until the deprecatedVector::Length()is not resolved.Unexpected changes: some source lines modified by removing trailing whitespaces on file save.
Need to revert them back?