[Rust] Added global namespace imports #5121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rw
suggested changes
Jan 16, 2019
rw
suggested changes
Jan 17, 2019
rw
suggested changes
Jan 17, 2019
src/idl_gen_rust.cpp
Outdated
| code_ += ""; | ||
| code_ += indent + "extern crate flatbuffers;"; | ||
| code_ += indent + "use self::flatbuffers::EndianScalar;"; | ||
| code_ += ""; |
Contributor
There was a problem hiding this comment.
Let's delete this whitespace line.
784de45 to
a7564b9
Compare
rw
approved these changes
Jan 18, 2019
aardappel
approved these changes
Jan 24, 2019
Collaborator
|
Thanks :) |
zchee
pushed a commit
to zchee/flatbuffers
that referenced
this pull request
Feb 14, 2019
* [Rust] Added global namespace imports * Documented the need for global imports * Added white_space params to GenNamespaceImports * Removed a \n from GenNamespaceImports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5116 .