Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@find
Copy link
Contributor

@find find commented Jan 24, 2019

There're ZWSP <U+200B>'s in util.h, and my MSVC was generating warning C4819 everywhere, I believe it's better to get rid of them

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@find
Copy link
Contributor Author

find commented Jan 24, 2019

Signed it

@googlebot
Copy link

CLAs look good, thanks!

@vglavnyy
Copy link
Contributor

Thank you for the fix.
These typos was added by 4ed6faf.
The MSVC2017 and VSCode open this file as UTF-8 without BOM, therefore, they are invisible in editors and during compilation.

@aardappel
Copy link
Collaborator

Thanks!

@aardappel aardappel merged commit 347dba8 into google:master Jan 24, 2019
zchee pushed a commit to zchee/flatbuffers that referenced this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants