[C++]Make changes on the make_unsigned type trait #5136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33c9485 to
1e76492
Compare
Collaborator
|
Thanks! I don't understand the message change though, as this feature is implemented using template specialization. |
Contributor
Author
|
@aardappel I thought the original author was trying to use the word |
Collaborator
|
Yes, I don't think |
Contributor
Author
|
I see. I've unchanged the message, fixing the typo only. |
Fix a typo in the static assert message in `make_unsigned` Support more specifications for `make_unsigned`
Collaborator
|
CI error appears unrelated, merging, thanks! |
zchee
pushed a commit
to zchee/flatbuffers
that referenced
this pull request
Feb 14, 2019
Fix a typo in the static assert message in `make_unsigned` Support more specifications for `make_unsigned`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo in the static assert message in
make_unsignedSupport more specifications for
make_unsignedThank you for submitting a PR!
Please make sure you include the names of the affected language(s) in your PR title.
This helps us get the correct maintainers to look at your issue.
If you make changes to any of the code generators, be sure to run
cd tests && sh generate_code.sh(or equivalent .bat) and include the generatedcode changes in the PR. This allows us to better see the effect of the PR.
If your PR includes C++ code, please adhere to the Google C++ Style Guide,
and don't forget we try to support older compilers (e.g. VS2010, GCC 4.6.3),
so only some C++11 support is available.
Include other details as appropriate.
Thanks!