[C#] Add support to copy an arraysegment into flatbuffer #5417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardappel
reviewed
Jun 27, 2019
Collaborator
aardappel
left a comment
There was a problem hiding this comment.
Generally looks good, thanks! If we could reduce on the code duplication a bit, that be great though.
| /// <param name="offset">The offset into this buffer where the copy will end</param> | ||
| /// <param name="x">The array to copy data from</param> | ||
| /// <returns>The 'start' location of this buffer now, after the copy completed</returns> | ||
| public int Put<T>(int offset, ArraySegment<T> x) |
Collaborator
There was a problem hiding this comment.
a fair bit of code in here is shared with the span case, does it make sense to lift some of it out into common functions, assuming it won't affect performance too much?
Collaborator
|
Related: #5419 |
f381fd7 to
31f8799
Compare
f116b80 to
f12cca8
Compare
Contributor
|
This pull request is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when not compiled with
Spanenabled there is no way to add a segment of an array in a performant manner.ArraySegmentis utilized as the alternative toSpanin most cases throughout the library and generated code, but Add/Put aren't replicated when 'Span' is not enabled. This is specifically useful for nested flatbuffers where just the used segment of a ByteBuffer can be copied into the parent flatbuffer without an intermediate copy.