Rust: Fixed cargo clippy on non-generated code #5485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2019 11:05
Contributor
|
@CasperN Cool! Looks like you also added some code along with the clippy stuff? |
CasperN
commented
Aug 16, 2019
rust/flatbuffers/src/primitives.rs
Outdated
| pub struct TableFinishedWIPOffset {} | ||
|
|
||
| /// TableUnfinishedWIPOffset marks a WIPOffset as being for an unfinished table. | ||
| // TableUnfinishedWIPOffset marks a WIPOffset as being for an unfinished table. |
Collaborator
Author
There was a problem hiding this comment.
oh that's my bad - that should still be a doc comment
Collaborator
Author
|
I fixed the clippy lints, which involved writing some code (e.g. replace the assert_eq for floats) and also I added more derives |
Collaborator
|
Ignore Travis Android CI fail. |
Collaborator
Author
|
Thanks Wouter, I was wondering how'd that break |
Collaborator
Author
|
@rw care to comment? |
rw
suggested changes
Aug 22, 2019
Contributor
rw
left a comment
There was a problem hiding this comment.
After further discussion this will LGTM
Collaborator
Author
|
Bump @rw |
Contributor
|
@CasperN awesome work! Added more comments. Thanks for the bump :-] |
rw
approved these changes
Sep 6, 2019
Contributor
|
LGTM, merge when CI passes. |
Collaborator
|
CI problem unrelated. |
LuckyRu
pushed a commit
to LuckyRu/flatbuffers
that referenced
this pull request
Oct 2, 2020
* Cargo clippy lints * more lints * more lints * Restored a doc comment * Comment on float eps-eq and adjusted casting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a small test PR. There should be no behavioral changes, just removing lints from cargo clippy in the non generated code.