Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Javascript] Fix syntax error for signed enum #5503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aardappel merged 2 commits into from
Sep 5, 2019
Merged

[Javascript] Fix syntax error for signed enum #5503

aardappel merged 2 commits into from
Sep 5, 2019

Conversation

@nullbus
Copy link
Contributor

@nullbus nullbus commented Sep 2, 2019

This fixes #5497.

I added a test case to ensure it's working. But typescript and dart tests are failing for other reason.

@aardappel
Copy link
Collaborator

aardappel commented Sep 3, 2019

Thanks, nice fix!

The CI error for C# will probably go away if you add at line 78 of tests/FlatBuffers.Test/FlatBuffers.Test.csproj something like:

<Compile Include="..\MyGame\Example\Race.cs">
  <Link>MyGame\Example\Race.cs</Link>
</Compile>

@nullbus
Copy link
Contributor Author

nullbus commented Sep 4, 2019

Thank you for pointing out. I have applied fix and it seems ok to C# side. But another CI failure occurs at Windows c++. Could I pass it?

@aardappel
Copy link
Collaborator

aardappel commented Sep 5, 2019

The other CI error doesn't appear to be related to you. We can merge and fix that later.

@aardappel aardappel merged commit 4b870ac into google:master Sep 5, 2019
LuckyRu pushed a commit to LuckyRu/flatbuffers that referenced this pull request Oct 2, 2020
@nullbus @LuckyRu
[Javascript] Fix syntax error for signed enum (google#5503)
8d10697 
* wrap quotes to enum name map to prevent syntax errorn when enum value is negative

* Add a test that covers signed enum case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Javascript] Negative enum value causes syntax error

2 participants

@nullbus @aardappel